review-verification-protocol-9583a7 — independently scanned and version-tracked by SaferSkills.
SaferSkills independently audited review-verification-protocol-9583a7 (Agent Skill) and scored it 100/100 (green). The audit ran 55 deterministic rules across Security, Supply Chain, Maintenance, Transparency, and Community; it found 0 high-severity and 0 lower-severity findings. The full rule-by-rule trace and per-finding evidence are below. Free, methodology-open.
Findings & checks · 0 flagged
Every scanned point with the score it earned and what moved between them.
First recorded scan — no prior version to compare against.
The primary manifest — the file an agent reads to learn what this artifact does.
This protocol MUST be followed before reporting any code review finding. Skipping these steps leads to false positives that waste developer time and erode trust in reviews.
Before issuing any verdict — flag, reject, or downgrade a finding — you MUST echo the exact artifact you are judging, quoted from a source you read in this turn:
The artifact is the only source of truth. Never infer what you are reviewing from the branch name, the working directory, surrounding files, or recollection. If your mental model differs from the freshly read source, the source wins. A verdict issued without a same-turn echo of its target is invalid — emit the echo first, or do not emit the verdict.
This gate exists because an LLM under contextual priming will confidently flag code that is not in the file. It runs before the hard gates below.
Run these in order. Do not move to the next gate until its pass condition is met (objective evidence, not internal certainty).
Pass: You can name the symbol and cite at least one line outside the changed lines that shows control flow, scope, or use relevant to the finding.
@objc/#selector/SPM symbols that could reference it.Pass: Recorded outcome: match count or list, or explicit “zero matches in repo” before asserting unused.
View / coordinator / ViewModel, app or scene delegate pipeline, or documented framework behavior that might already enforce the rule.Pass: One sentence naming where responsibility lives, or “checked caller + framework path; still missing” with which layer you checked.
Pass: Chosen label matches a bullet under that severity; otherwise downgrade, reclassify as Informational, or omit.
[FILE:LINE] plus a one-line proof; complete Before Submitting Review steps 1–7 for this review.Pass: Every step satisfied or the finding was removed or downgraded.
The checklist below expands these gates by issue type; use both.
Before flagging ANY issue, verify:
Before flagging, you MUST:
public/open and used by other modules or targets (SPM, app extensions)#selector, key paths, or dynamic dispatchCommon false positives:
@State, @Binding, @Observable) that drives updates even when the binding looks “unused” in one branch#Preview, tests, or other targets@objc, #selector, or dynamic dispatch to a symbol search may not show as plain call sitesBefore flagging, you MUST:
ViewModel, coordinator, app/scene delegate)Codable, property wrappers, URLSession APIs)Result, async error path, user-facing alert elsewhere)Common false positives:
do/catchBefore flagging, you MUST:
Valid patterns often flagged incorrectly:
// Type annotation, NOT forced unwrap
let data: UserData = await loader()
// Type narrowing makes this safe
if let user = data as? User {
user.name // Swift knows this is User
}Before flagging, you MUST:
deinit, onDisappear, cancel(), or store teardown elsewhere)Task cancellation, AsyncSequence termination, or Combine subscription disposal is handled after awaitsCommon false positives:
[weak self] or [unowned self] already used where neededTask is cancelled when the view disappears (reviewer missed the link)Before flagging, you MUST:
@Observable granularity)Do NOT flag:
ONLY use for:
Use for:
Use for:
Use for:
These are NOT review blockers. They should be noted for the author's awareness but must not appear in the actionable issue count. The Verdict should ignore informational items entirely.
| Pattern | Why It's Valid |
|---|---|
guard let early return | Standard Swift pattern for unwrapping, not excessive nesting |
weak self in closures | Required for breaking retain cycles, not unnecessary |
@State / @Binding property wrappers | SwiftUI state management primitives |
Optional chaining (foo?.bar?.baz) | Safe access pattern, not error suppression |
as? conditional cast | Safer than force cast, correct for type narrowing |
| Pattern | Why It's Valid |
|---|---|
@StateObject in parent, @ObservedObject in child | Correct ownership pattern |
| View body computed property without caching | SwiftUI manages re-rendering efficiently |
AnyView for heterogeneous lists | Valid when @ViewBuilder or generics aren't practical |
EnvironmentObject injection | Standard SwiftUI dependency injection |
PreferenceKey for child-to-parent data | Correct alternative to callbacks for layout data |
| Pattern | Why It's Valid |
|---|---|
XCTAssertEqual without custom message | Default messages are often sufficient |
async let in test methods | Valid for concurrent test setup |
@MainActor test classes | Required when testing UI-bound code |
| Mock objects without protocol conformance | Simple test doubles are acceptable |
| Pattern | Why It's Valid |
|---|---|
+? lazy quantifier in regex | Prevents over-matching, correct for many patterns |
| Direct string concatenation | Simpler than template literals for simple cases |
| Multiple returns in function | Can improve readability |
| Comments explaining "why" | Better than no comments |
Flag force unwrap (!) ONLY IF ALL of these are true:
guard let or if let protects the access@IBOutlet (which is conventionally force-unwrapped)Flag complex View body ONLY IF:
Flag missing do/catch ONLY IF:
Result type wraps the throwing callFinal verification:
[FILE:LINE] ISSUE_TITLEIf uncertain about any finding, either:
~30 seconds. Free. No account. Every finding cites a rule and a line of evidence.