makefile-best-practices — independently scanned and version-tracked by SaferSkills.
SaferSkills independently audited makefile-best-practices (Agent Skill) and scored it 100/100 (green). The audit ran 55 deterministic rules across Security, Supply Chain, Maintenance, Transparency, and Community; it found 0 high-severity and 0 lower-severity findings. The full rule-by-rule trace and per-finding evidence are below. Free, methodology-open.
Findings & checks · 0 flagged
Every scanned point with the score it earned and what moved between them.
First recorded scan — no prior version to compare against.
The primary manifest — the file an agent reads to learn what this artifact does.
Target: GNU Make 4.x. Covers Make as both a build system (dependency-driven compilation) and a task runner (developer workflow automation).
On the `dev` plugin. Its members are grouped by "general development tooling", not by a shared workflow — this skill has no dependency on `baml-expert`, `jinja-expert`, or `transformers-config-tokenizers-expert`, and none of them on it. Don't hunt for a pipeline that isn't there. The one overlap worth knowing: a Makefile that shells out to render templates is still a Makefile question here, but the template body itself is jinja-expert.
Targets represent outputs; prerequisites represent inputs; recipes transform inputs → outputs. Think graph-first.
# WRONG: Script thinking - order-dependent, breaks with -j
build:
compile src/a.c
compile src/b.c
link
# RIGHT: Graph thinking - declares real dependencies
program: a.o b.o
$(CC) -o $@ $^
%.o: %.c
$(CC) -c $< -o $@make -j is the Real BarIf it breaks with parallel builds, it's broken. Always declare real dependencies.
# WRONG: Hidden dependency, races under -j
generated.h:
./generate-header.sh > $@
main.o: main.c # Missing: generated.h
$(CC) -c $< -o $@
# RIGHT: Explicit dependency
main.o: main.c generated.h
$(CC) -c $< -o $@Validate dependency correctness with make --shuffle=random -j (GNU Make 4.4+). Randomizing prerequisite order exposes missing edges that a fixed order hides.
Use .PHONY for commands, not for artifacts. Understanding timestamps is 80% of Make proficiency.
.PHONY: clean test lint help # Commands - always run
# Don't mark file-producing targets as phony# := immediate (evaluated when defined) - use for $(shell), most cases
FILES := $(shell find src -name '*.c')
# = deferred (evaluated when used) - use when referencing later-defined vars
CFLAGS = $(BASE_FLAGS) $(EXTRA_FLAGS)
# ?= conditional (set only if undefined) - use for user-overridable defaults
PREFIX ?= /usr/local
CC ?= gcc$(shell ...) with = re-runs the command every time the variable is expanded — always use := for shell captures unless repeated execution is intentional.
| Variable | Meaning |
|---|---|
$@ | Target name |
$< | First prerequisite |
$^ | All prerequisites (deduped) |
$? | Prerequisites newer than target |
$* | Stem matched by % |
$(@D) | Directory part of target |
$(BUILD_DIR)/%.o: src/%.c | $(BUILD_DIR)
@mkdir -p $(@D)
$(CC) $(CFLAGS) -c $< -o $@The essential hygiene directives plus a self-documenting help target. For a production-ready template with verbosity toggle, color output, and a GNU Make 4.0+ compatibility check, see `references/Makefile.gnumake-template`.
Each line of the preamble matters:
| Directive | Effect |
|---|---|
SHELL := bash | Use bash (not /bin/sh/dash) for richer recipe syntax |
.SHELLFLAGS := -eu -o pipefail -c | Unset vars, errors, and pipe failures all abort the recipe |
.DELETE_ON_ERROR: | Remove the target file on recipe failure — prevents stale half-built artifacts |
--warn-undefined-variables | Catch typos in variable names at parse time |
--no-builtin-rules | Strip implicit rules for faster parsing and explicit semantics |
.DEFAULT_GOAL := help | Bare make prints help instead of building the first target |
SHELL := bash
.SHELLFLAGS := -eu -o pipefail -c
.DELETE_ON_ERROR:
MAKEFLAGS += --warn-undefined-variables --no-builtin-rules
.DEFAULT_GOAL := help
.PHONY: build test clean help
build: ## Build the project
go build ./...
test: ## Run tests
go test ./...
clean: ## Remove build artifacts
rm -rf build/
help: ## Show this help
@grep -E '^[a-zA-Z_-]+:.*?## .*$$' $(MAKEFILE_LIST) | \
awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-15s\033[0m %s\n", $\$1, $\$2}'##@ Section Headers — Group the TargetsThe target above prints one flat alphabetical list and encodes no ordering. Use ##@ headers instead whenever the Makefile is a procedure (release pipeline, upgrade, migration) rather than a set of independent tasks. This is the kubebuilder / operator-sdk convention:
help: ## Show this help
@awk 'BEGIN{FS=":.*?## "} \
/^##@/{printf "\n\033[1m%s\033[0m\n", substr($\$0,5); next} \
/^[a-zA-Z_0-9-]+:.*?## /{printf " \033[36m%-14s\033[0m %s\n",$\$1,$\$2}' $(MAKEFILE_LIST)
##@ 1 · Build
build: ## Compile the binary
test: ## Run tests
##@ 2 · Release
push: ## Push the image1 · Build
build Compile the binary
test Run tests
2 · Release
push Push the imagesubstr($\$0,5) strips ##@ ; next stops the header line also matching thetarget rule.
reads top-to-bottom and an agent gets the same ordering with no separate runbook to drift out of sync.
##@ Help line before the help target itself, or it lands underwhatever section precedes it.
.DEFAULT_GOAL := help.# BAD: Rebuilds when ANY file added to dir (timestamp changes)
$(objs): $(BUILD_DIR)
# GOOD: Only checks existence, not timestamp
$(objs): | $(BUILD_DIR)
$(BUILD_DIR):
mkdir -p $@CPPFLAGS += -MMD -MP
-include $(deps)Flags: -MMD generates .d files, -MP adds phony targets for headers (prevents errors if deleted).
For rules producing multiple outputs, use &: instead of sentinel files:
# Modern: grouped target
parser.c parser.h &: parser.y
bison -d $<
# Legacy: sentinel file pattern
.parser.sentinel: parser.y
bison -d $<
touch $@
parser.c parser.h: .parser.sentinelSee `references/recipe-patterns.md` — per-target CFLAGS, the reusable guard-% rule for gating destructive targets on an env var instead of a stdin prompt that deadlocks CI, and NO_COLOR-respecting output.
# AVOID: Incomplete dependency graph, poor -j performance
all:
$(MAKE) -C lib
$(MAKE) -C src # Can't see lib's deps!
# PREFER: Non-recursive with includes
include lib/module.mk
include src/module.mkIf recursion is necessary, always use $(MAKE) not make (preserves jobserver).
cd Bug# WRONG: Each line runs in separate shell
install:
cd /usr/local
cp myapp bin/ # Runs in original directory!
# RIGHT: Chain commands
install:
cd /usr/local && cp myapp bin/
# OR: Use .ONESHELL (changes all recipes)Never inline a heredoc in a recipe — same root cause, unrecognisable symptom. Each line still gets its own shell, so the heredoc body runs as shell commands:
# WRONG
gen:
python3 - <<'PY'
print("hello")
PY/bin/sh: -c: line 1: syntax error near unexpected token `"hello"'On a terminal it does not even error: python3 - inherits stdin, never sees EOF, and the build hangs. .ONESHELL: does not fix it — recipe tabs are preserved, so the PY terminator stops matching at column 0 and leaks into stdout. Use a sidecar script:
# RIGHT
gen:
python3 scripts/gen.py# BAD: CI failures are impossible to debug
build:
@$(CC) -o $@ $^
# GOOD: Verbosity toggle
build:
$(Q)$(CC) -o $@ $^
# Run: make V=1 for verbose# BAD: Bashisms without declaring bash
build:
[[ -f config ]] && source config # Fails on /bin/sh
# GOOD: Declare shell or use POSIX
SHELL := bash
# OR use POSIX: [ -f config ] && . configFlag table, diagnostic functions and symptom-to-cause table for a misbehaving Makefile, plus the GNU vs BSD vs POSIX 2024 feature matrix and shell-portability rules: `references/debugging-portability.md`.
For Helm chart and Kubernetes Makefile patterns, consult `references/Makefile.helm-k8s` (452 lines, 47 targets). Key principles:
CHART_NAME, VERSION),derive all artifact names — eliminates hardcoding
verify-context target that checkskubectl config current-context against an allowed list; all mutating targets depend on it
KUBECTL_EXTERNAL_DIFF in Makefiles — users have their own diff viewersReference files are catalogs of patterns to pick from, not templates to copy wholesale. Real-world Makefiles typically use 10-20 targets.
Makefile.gnumake-template - Modern GNU Make skeletonMakefile.go - Go project patternsMakefile.python - Python development workflowMakefile.node - Node.js with npm integrationMakefile.docker - Docker build/push patternsMakefile.helm-k8s - Helm charts & Kubernetes operationsMakefile.portable - Cross-platform POSIX compatibleci-integration.md - CI/CD usage patternsrecipe-patterns.md - Target-specific variables, CI guards, color outputdebugging-portability.md - Debug flags, symptom table, GNU/BSD/POSIX matrix~30 seconds. Free. No account. Every finding cites a rule and a line of evidence.